secured api_key against timing attacks #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1111 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 381 381
Lines 21897 21898 +1
=======================================
+ Hits 21759 21760 +1
Misses 138 138 |
| @@ -66,7 +67,7 @@ async def send_message(transport, payload, endpoint, api_key): | |||
| send_message(transport, "{}", endpoint=server_addr, api_key=api_key), 5.0 | |||
| ) | |||
| assert self.message_results == [{}] | |||
| assert self.headers.get("x-api-key") == api_key | |||
| assert api_key and compare_digest(self.headers.get("x-api-key"), api_key) | |||
There was a problem hiding this comment.
I don't think there's any need to use this comparison method in the test
There was a problem hiding this comment.
okay, I'll remove it
Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
andrewwhitehead
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wadeking98 wkingnumber2@gmail.com
@andrewwhitehead
comparing user input to secrets and then responding makes this application vulnerable to timing attacks. See resource here: https://blog.sqreen.com/developer-security-best-practices-protecting-against-timing-attacks/
While an attacker isn’t likely to be able to exploit this from somewhere over the internet due to network jitter, they might be able to pull it off if the agent ever supports TOR, HTTP/2 (timeless timing attack), or if they get access to a pod inside the same openshift cluster that can send requests to the agent (ie: the api pod)