Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-2 base64url consistency #1188

Closed
wants to merge 6 commits into from

Conversation

shaangill025
Copy link
Contributor

  • In regards to decoding, we handle base64 permissively, passing urlsafe as True.
  • If emit_new_didcomm_mime_type and emit_new_didcomm_prefix arguments are set, send everything as base64url [updates data_base64 accordingly] else leave eveything as it is.
    closes raw base64url consistency? #1108

@swcurran
Copy link
Member

The concern I have is the use of the emit_new_didcomm_mime_type and emit_new_didcomm_prefix arguments as the trigger. Should we have a separate aip2 argument as a trigger for a number of behaviours in ACA-Py? Alternative is a new one specifically for this, but aren't we trying to make a number of breaking changes at once?

@shaangill025
Copy link
Contributor Author

Can use --aip-version argument as the trigger, once the following PR is merged.
#1056

Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
…t-python into issue#1108

Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
Signed-off-by: Shaanjot Gill <shaangill025@users.noreply.github.com>
@shaangill025
Copy link
Contributor Author

This PR should be ready, it needs minor change [uncommenting # if self._session.profile.settings.get_value("aip_version", 1) >= 2] once #1056 is merged into main.

@dbluhm
Copy link
Member

dbluhm commented Jul 5, 2023

@shaangill025 Is this PR still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

raw base64url consistency?
3 participants