Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_demo fails if ../logs folder doesn't exist #1223

Merged
merged 3 commits into from Jun 23, 2021

Conversation

eabadjiev
Copy link
Contributor

Steps to reproduce:

  1. Clone repo
  2. cd demo
  3. run_demo faber

Expected:

  • to start the demo connection flow

Actual:

  • fails with:
./run_demo faber                                             
Preparing agent image...
sha256:5c8d0c8453ec05bcd7ff2e234267e09e113ac041707cb4f21a22f613f832727c
Trying to detect ngrok service endpoint
jq not found
192.168.65.3
docker: Error response from daemon: Mounts denied: 
The path ..../aries-cloudagent-python/demo/../logs
is not shared from OS X and is not known to Docker.
You can configure shared paths from Docker -> Preferences... -> File Sharing.
See https://docs.docker.com/docker-for-mac/osxfs/#namespaces for more info.
.
ERRO[0000] error waiting for container: context canceled 

The proposed fix assumes that logs are only required when --timing in enabled.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2021

Codecov Report

Merging #1223 (405f35e) into main (2dc24b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1223   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files         466      466           
  Lines       26853    26853           
=======================================
  Hits        26372    26372           
  Misses        481      481           

@eabadjiev eabadjiev force-pushed the main branch 2 times, most recently from d9e146e to a45a766 Compare June 7, 2021 15:01
Signed-off-by: Emo Abadjiev <emo@tumba.solutions>
@eabadjiev
Copy link
Contributor Author

Updated DCO sign-off and rebased vs latest main.

@andrewwhitehead andrewwhitehead merged commit e942292 into hyperledger:main Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants