Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAA Fixes #133

Merged
merged 5 commits into from Aug 10, 2019
Merged

TAA Fixes #133

merged 5 commits into from Aug 10, 2019

Conversation

dbluhm
Copy link
Member

@dbluhm dbluhm commented Aug 10, 2019

Fixed a couple of KeyErrors and fixed the timing of acceptance which was formerly too precise and was being rejected by the Indy ledger.

Signed-off-by: Daniel Bluhm <daniel.bluhm@sovrin.org>
Signed-off-by: Daniel Bluhm <daniel.bluhm@sovrin.org>
@andrewwhitehead
Copy link
Member

@dbluhm The syntax checker is failing on a couple long lines, I'd suggest running flake8 on those two files: pip install flake8; python -m flake8 {path}

Signed-off-by: Daniel Bluhm <daniel.bluhm@sovrin.org>
Signed-off-by: Daniel Bluhm <daniel.bluhm@sovrin.org>
@codecov-io
Copy link

Codecov Report

Merging #133 into master will decrease coverage by <.01%.
The diff coverage is 40%.

@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage    72.2%   72.19%   -0.01%     
==========================================
  Files         188      188              
  Lines        8198     8200       +2     
==========================================
+ Hits         5919     5920       +1     
- Misses       2279     2280       +1

@andrewwhitehead andrewwhitehead merged commit dd8620a into hyperledger:master Aug 10, 2019
@dbluhm dbluhm deleted the taa-fixes branch February 21, 2020 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants