Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: accept taa using startup parameter --accept-taa #1643

Merged
merged 3 commits into from
Feb 24, 2022

Conversation

TimoGlastra
Copy link
Member

Adds option to accept the TAA using config parameters in addition to the Admin API and using TTY.

The TAA can be accepted by providing a valid acceptance mechanism, and specifying the version. This is to make sure newer versions of the TAA aren't automatically accepted. If the version does not match, or the acceptance mechanism doesn't exist in the aml, an error is thrown and the process is terminated (this seems fine to me as it is run on startup and can be fatal to using the agent).

The configuration is as follows:

--accept-taa on_file 1.0

or in the yml config:

accept-taa: [on_file, 1.0]

Fixes #1532

Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
Signed-off-by: Timo Glastra <timo@animo.id>
@codecov-commenter
Copy link

Codecov Report

Merging #1643 (7c241aa) into main (e29e6ef) will decrease coverage by 0.11%.
The diff coverage is 79.31%.

@@            Coverage Diff             @@
##             main    #1643      +/-   ##
==========================================
- Coverage   95.67%   95.55%   -0.12%     
==========================================
  Files         528      528              
  Lines       32649    32670      +21     
==========================================
- Hits        31236    31218      -18     
- Misses       1413     1452      +39     

Copy link
Member

@andrewwhitehead andrewwhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I like that it requires passing the current TAA version.

@andrewwhitehead andrewwhitehead merged commit ecf2f28 into main Feb 24, 2022
@andrewwhitehead andrewwhitehead deleted the feat/accept-taa-args branch February 24, 2022 23:34
@swcurran swcurran changed the title feat: accept taa using config feat: adds startup parameter to accept taa Apr 7, 2022
@swcurran swcurran changed the title feat: adds startup parameter to accept taa feat: accept taa using startup parameter --accept-taa Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to accept TAA using startup parameters
3 participants