Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow self-connected agent to issue credentials, present proof #179

Merged
merged 2 commits into from Sep 12, 2019
Merged

allow self-connected agent to issue credentials, present proof #179

merged 2 commits into from Sep 12, 2019

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Sep 11, 2019

The v0.1 approach of selecting model record by initiator tag (filter) would not fly for v1.0 (issue-credential, present-proof) protocols: either side may initiate. Instead, select by connection identifier, available from the request context.

While altering manager.py for both, get message data from context where possible (i.e., unless routes.py instantiates and calls manager without the request context that corresponding handlers have).

Signed-off-by: sklump srklump@hotmail.com

Signed-off-by: sklump <srklump@hotmail.com>
@codecov-io
Copy link

Codecov Report

Merging #179 into master will decrease coverage by 0.05%.
The diff coverage is 23.8%.

@@            Coverage Diff             @@
##           master     #179      +/-   ##
==========================================
- Coverage   71.73%   71.67%   -0.06%     
==========================================
  Files         217      217              
  Lines        9820     9826       +6     
==========================================
- Hits         7044     7043       -1     
- Misses       2776     2783       +7

Signed-off-by: sklump <srklump@hotmail.com>
@andrewwhitehead andrewwhitehead merged commit b4275b1 into hyperledger:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants