Reduce impact of tags in non-secrets #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
andrewwhitehead
commented
Oct 25, 2019
andrewwhitehead
commented
- Avoid fetching tags on BaseRecord models
- Reduce the tags applied to current BaseRecord models
- Add in-memory filtering for values that were previously tags
- Implement caching by thread ID in the (v0.1) CredentialManager
Codecov Report
@@ Coverage Diff @@
## master #235 +/- ##
==========================================
+ Coverage 72.98% 73.06% +0.07%
==========================================
Files 219 219
Lines 10174 10187 +13
==========================================
+ Hits 7426 7443 +17
+ Misses 2748 2744 -4 |
…umber of tags Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
…query methods Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
less-tags
branch
from
814940b
to
d269d40
Compare
nrempel
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.