Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.10.2 Patch Release - fix issue #2475, #2477 #2482

Merged
merged 3 commits into from
Sep 7, 2023
Merged

0.10.2 Patch Release - fix issue #2475, #2477 #2482

merged 3 commits into from
Sep 7, 2023

Conversation

shaangill025
Copy link
Contributor

@shaangill025 shaangill025 commented Sep 7, 2023 •
edited
Loading

Re 0.10.2-rc0 patch release

@dbluhm @shaangill025
fix: unique ids for services in legacy peer
c8e660c 
Signed-off-by: Daniel Bluhm <dbluhm@pm.me>
@dbluhm
Copy link
Member

dbluhm commented Sep 7, 2023

There's something funky going on here; the commit currently in this PR is already on the 0.10.2 branch: 9ccf56a

@shaangill025 shaangill025 changed the base branch from 0.10.2 to main September 7, 2023 19:07
@shaangill025 shaangill025 changed the base branch from main to 0.10.2 September 7, 2023 19:07
@shaangill025
Merge branch '0.10.2' of https://github.com/hyperledger/aries-cloudag…
ed2c289 
…ent-python into 0.10.2_release
@shaangill025
fix issue_2477
468f1e3 
Signed-off-by: Shaanjot Gill <gill.shaanjots@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@shaangill025
Copy link
Contributor Author

shaangill025 commented Sep 7, 2023 •
edited
Loading

@dbluhm Should be fixed now, will take it out of draft as soon as #2480 is merged.

@shaangill025 shaangill025 marked this pull request as ready for review September 7, 2023 21:00
@swcurran swcurran merged commit 635d25e into hyperledger:0.10.2 Sep 7, 2023
7 checks passed
@swcurran
Copy link
Member

swcurran commented Sep 8, 2023

We've lost #2475 from the main branch -- it's been closed but not merged. Doesn't look right...

@dbluhm -- can you check? 0.10.2 looks right to me -- has both PRs, but does main?

@usingtechnology usingtechnology mentioned this pull request Sep 15, 2023
Closed
@loneil loneil mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbluhm dbluhm Awaiting requested review from dbluhm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shaangill025 @dbluhm @swcurran