Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anoncreds multitenant endorsement integration tests #2801

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

jamshale
Copy link
Contributor

@jamshale jamshale commented Feb 20, 2024

So, I had a misunderstanding. Endorsement for anoncreds in multitenancy is currently working when the admin agent is askar-anoncreds wallet type and the tenants are created with askar-anoncreds wallet type.

This PR will just add integration tests for this scenario.

I think it's important to have the feature #2786 available for multitenancy going forward as this is where some of my confusion came from. When I first thought this didn't work, the author tenant wasn't setup completely. (It's pretty much finished other than some unit testing problems)

The other issue somewhat related to this issue is #2792 but work can be done off of this issue as it is more relevant.

I'm thinking about how this is going to work with the admin agent on askar and a tenant is on askar-anoncreds and vice versa, and how this is going to work with the upgrade script etc. Currently this doesn't work because the wallet type of the admin agent is what decides what endpoints are available.

I don't think these questions are related to this ticket though so the tests should be enough to close this issue.

@jamshale jamshale linked an issue Feb 20, 2024 that may be closed by this pull request
@jamshale jamshale marked this pull request as ready for review February 20, 2024 18:27
@ianco
Copy link
Member

ianco commented Feb 20, 2024

I'm thinking about how this is going to work with the admin agent on askar and a tenant is on askar-anoncreds and vice versa, and how this is going to work with the upgrade script etc. Currently this doesn't work because the wallet type of the admin agent is what decides what endpoints are available.

Per @swcurran 's comments about the upgrade process (askar to askar-anoncreds) I think we'll need to have a consistent set of API's available for the two wallet types. Not sure why it's not working but endorsement definitely "should" work between the askar and askar-anoncreds wallet types.

There are other issues with how the endorser/author connection is setup but we have a couple of issues open on this topic.

ianco
ianco previously approved these changes Feb 20, 2024
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Signed-off-by: jamshale <jamiehalebc@gmail.com>
Copy link

sonarcloud bot commented Feb 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jamshale
Copy link
Contributor Author

jamshale commented Feb 20, 2024

Not sure how I did this after testing locally but I spelled multitenant wrong as the option and this caused the tests to hang.

I also slightly reduced the amount of endorsement tests for GHA. They are getting pretty long and the few I removed are covered by the other tests.

@ianco ianco merged commit cfa8cb5 into hyperledger:main Feb 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Anoncreds - Multitenancy - Endorsement
2 participants