fix: fixes a regression that requires a log file in multi-tenant mode

[amanji]

This fixes a regression introduced by #2870 that required a log file to be present on file when using the default config setup for multi-tenant mode. The log file is only required if the user specifically sets the --log-file startup param.

[jamshale]

I don't see anything wrong with the changes made, but several integration tests are failing related to the logging config.

[swcurran]

@amanji — are you on this?

[amanji]

@swcurran Yes. Just running local tests

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[jamshale]

FYI. The last fail wasn't related to the PR. I've seen it a couple times lately and I'm pretty sure it's related to the von-network nodes getting out of sync.

It may help to wait longer for this test. Or a script to occasionally sync up the nodes.

[jamshale]

Honestly, I'm still a bit confused by all this logging files and different configurations. I'm going to approve it though as you have detailed comments and looks like you've got a solid understanding.

[amanji]

It has been just as perplexing to me having gone through the code a few times. There are likely some historical design decisions that I'm not aware of. I do think this can be distilled further down but probably best left for another refactor.

[swcurran]

From an outsider, I can’t figure out why there is any configuration beyond the location of the file. AFAIK, what we need is to add the tenant ID to the log, so that later when the logs are processed, they can be separated. That should be the same whether it is single vs. multi-tenent.

Or are we splitting the logs at the source and writing each one to a separate file?

Is there a description of the design that to review. I’ve not looked at it, so I could be way off.