Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example integration test issuing 2 credentials under the same schema #2948

Merged
merged 1 commit into from
May 14, 2024

Conversation

ianco
Copy link
Member

@ianco ianco commented May 14, 2024

No description provided.

Signed-off-by: Ian Costanzo <ian@anon-solutions.ca>
@ianco ianco requested a review from jamshale May 14, 2024 17:34
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@jamshale jamshale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was pretty much exactly what I was trying to do. Thanks for the example!

@ianco ianco merged commit f37bc91 into hyperledger:main May 14, 2024
8 checks passed
@swcurran
Copy link
Member

When we added this test, can we delete one that just does a single issueance, since this one covers that? Nice to keep the time to run the suite shorter…. :-). Not sure it is worth such an effort to eliminate duplicates, but the tests take a long time to run these days.

@ianco
Copy link
Member Author

ianco commented May 14, 2024

When we added this test, can we delete one that just does a single issueance, since this one covers that? Nice to keep the time to run the suite shorter…. :-). Not sure it is worth such an effort to eliminate duplicates, but the tests take a long time to run these days.

The run for each PR includes all tests tagged as @GHA, so we can control the scope of the PR tests with tags, rather than deleting tests.

For the new test I added I didn't include it in the @GHA scope, since it was just a demo for @jamshale . I agree we should review the scope of the @GHA tests and make sure we don't have too much duplication.

@swcurran
Copy link
Member

Sounds great. Agreed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants