Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix passing custom endpoint while accepting invitation #308

Merged

Conversation

gnarula
Copy link
Contributor

@gnarula gnarula commented Dec 13, 2019

my_endpoints is undefined if my_endpoint is passed to the method. The fix initializes my_endpoints in the else block

Signed-off-by: Gaurav Narula <gnarula94@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #308 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   87.36%   87.36%   +<.01%     
==========================================
  Files         236      236              
  Lines       11074    11075       +1     
==========================================
+ Hits         9675     9676       +1     
  Misses       1399     1399

Copy link
Member

@andrewwhitehead andrewwhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@andrewwhitehead andrewwhitehead merged commit fe686ce into hyperledger:master Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants