Allow side loading alternate inbound transports #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Bluhm <daniel.bluhm@sovrin.org>
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
==========================================
- Coverage 87.36% 87.36% -0.01%
==========================================
Files 236 236
Lines 11074 11078 +4
==========================================
+ Hits 9675 9678 +3
- Misses 1399 1400 +1 |
Signed-off-by: Daniel Bluhm <daniel.bluhm@sovrin.org>
andrewwhitehead
approved these changes
Jan 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a use case where there was a need to run both the "http" and "ws" transport on the same port. I wasn't sure a transport that combined both of these into one "http+ws" transport was something that was wanted upstream (if it is, I'm happy to address that separately) but I noticed that a couple of small tweaks would make it easy enough to side load my combined transport.
I'm curious how others feel about this approach.