Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notices #398

Merged
merged 2 commits into from Mar 3, 2020
Merged

Notices #398

merged 2 commits into from Mar 3, 2020

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Mar 3, 2020

Addresses #367
Signed-off-by: sklump srklump@hotmail.com

Signed-off-by: sklump <srklump@hotmail.com>
@codecov-io
Copy link

Codecov Report

Merging #398 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #398   +/-   ##
======================================
  Coverage      89%     89%           
======================================
  Files         236     236           
  Lines       11319   11319           
======================================
  Hits        10075   10075           
  Misses       1244    1244

@swcurran
Copy link
Member

swcurran commented Mar 3, 2020

Hey @sklump how did you construct the file? Manual or did you generate it? Thanks!

@sklump
Copy link
Contributor Author

sklump commented Mar 3, 2020

Manually. The tool is ancient and busted: python2, assumes licences included in packaging, and matches all files *.txt

@sklump
Copy link
Contributor Author

sklump commented Mar 3, 2020

It's not that bad once you're going. raw.github.com/user/repo/branch/filename downloads ASCII instead of html.

Copy link
Member

@andrewwhitehead andrewwhitehead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@andrewwhitehead andrewwhitehead merged commit 1aa7f24 into hyperledger:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants