revoke_credential -> revoke_credentials to allow more efficient implementation #435
Conversation
Codecov Report
@@ Coverage Diff @@
## master #435 +/- ##
==========================================
- Coverage 89.05% 89.05% -0.01%
==========================================
Files 248 248
Lines 12200 12205 +5
==========================================
+ Hits 10865 10869 +4
- Misses 1335 1336 +1 |
andrewwhitehead
force-pushed
the
revoke-multiple
branch
from
b481e35
to
3cabc4f
Compare
| result[registry_record.revoc_reg_id] = [ | ||
| cr_id for cr_id in registry_record.pending_pub | ||
| ] | ||
| result[registry_record.revoc_reg_id] = revoke_idxs |
There was a problem hiding this comment.
Doesn't this clobber any prior pending revocations? They won't make it into the delta, and they won't be pending anymore.
There was a problem hiding this comment.
I'm not sure I understand. It's doing the same thing as before, creating a combined delta from all the pending indexes, just doing that inside the IndyIssuer class instead. The credx issuer has an optimized path that creates a combined delta all at once.
There was a problem hiding this comment.
Oh - I missed a line. It's fine.
|
Please merge ASAP, I have a change or two in this space that I don't want to merge with it manually. |
…mentation; add issuance_by_default parameter to create-registry endpoint Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
andrewwhitehead
force-pushed
the
revoke-multiple
branch
from
3cabc4f
to
d23f14d
Compare
| delta_json = await indy.anoncreds.issuer_revoke_credential( | ||
| self.wallet.handle, tails_reader_handle, revoc_reg_id, cred_revoc_id | ||
| ) | ||
| if not result_json: |
There was a problem hiding this comment.
My two cents: if not ... else is a sign of overthinking.
There was a problem hiding this comment.
Maybe underthinking..
Also adds issuance_by_default parameter to create-registry endpoint
Fixes some method signatures in base classes