Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reliance on temp tails file #590

Merged
merged 4 commits into from
Jul 9, 2020

Conversation

sklump
Copy link
Contributor

@sklump sklump commented Jul 8, 2020

Addresses #584

Signed-off-by: sklump <srklump@hotmail.com>
Signed-off-by: sklump <srklump@hotmail.com>
Signed-off-by: sklump <srklump@hotmail.com>
@sklump
Copy link
Contributor Author

sklump commented Jul 8, 2020

Note that this gets rid of configuration for holder tails file storage location: every tails file always goes to $INDY_HOME/tails// locally, holder and issuer both.

@codecov-commenter
Copy link

Codecov Report

Merging #590 into master will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   96.48%   96.44%   -0.05%     
==========================================
  Files         247      247              
  Lines       13173    13190      +17     
==========================================
+ Hits        12710    12721      +11     
- Misses        463      469       +6     

Copy link
Contributor

@nrempel nrempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks good to me

@nrempel nrempel merged commit bd7e0aa into hyperledger:master Jul 9, 2020
nrempel added a commit to nrempel/aries-cloudagent-python that referenced this pull request Jul 21, 2020
…ails-file

Fix reliance on temp tails file
Signed-off-by: Nicholas Rempel <nick@lucent.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants