fixes#675 Align swagger schema get output. #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
=======================================
Coverage 98.98% 98.98%
=======================================
Files 251 251
Lines 13560 13560
=======================================
Hits 13423 13423
Misses 137 137 |
The swagger object for schema get indicates an object name of "schema_json" whilst the actual returned json in the body is "schema". Changing to have swagger object called "schema" to be consistent since this is what existing clients must have been forcing to for it to work. Signed-off-by: john court <jcourt@anonyome.com>
jcourt562
force-pushed
the
schemaget-openapi-interface
branch
from
87da3e8
to
fb26c47
Compare
jcourt562
changed the title
sklump
approved these changes
Aug 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The swagger object for schema get indicates an object name of
"schema_json" whilst the actual returned json in the body is "schema".
Changing to have swagger object called "schema" to be consistent
since this is what existing clients must have been forcing to for it to
work.