Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple invocation commands, implement start/provision/help commands #99

Merged
merged 10 commits into from
Jul 30, 2019

Conversation

andrewwhitehead
Copy link
Member

@andrewwhitehead andrewwhitehead commented Jul 24, 2019

  • Changes normal invocation from aca-py to aca-py start to run an agent
  • Adds support for additional commands, including aca-py provision wallet ... to create a wallet with an optional seed
  • Adds a --log-file parameter for redirecting log output without replacing the log config file

…let provisioning

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
… log config; update docs

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@codecov-io
Copy link

codecov-io commented Jul 24, 2019

Codecov Report

Merging #99 into master will increase coverage by 0.53%.
The diff coverage is 79.09%.

@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   72.79%   73.32%   +0.53%     
==========================================
  Files         178      183       +5     
  Lines        7523     7791     +268     
==========================================
+ Hits         5476     5713     +237     
- Misses       2047     2078      +31

Copy link
Contributor

@nrempel nrempel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Can you add some more thorough documentation on how to use these changes? We could use a little section in the dev readme and also a summary in the pull request description of the changes and how to use them.

Thanks

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
@nrempel nrempel merged commit 79306cc into hyperledger:master Jul 30, 2019
@andrewwhitehead andrewwhitehead deleted the split-commands branch February 29, 2020 21:45
mepeltier pushed a commit to mepeltier/aries-cloudagent-python that referenced this pull request Oct 31, 2022
…ttachments-api-updates

feat: update API endpoints to include supplements and attachments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants