fix(rest): ledger not found error

Signed-off-by: Timo Glastra <timo@animo.id>
openwallet-foundation · Apr 14, 2022 · 2374b42 · 2374b42
1 parent 4378ca6
commit 2374b42
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/rest/src/controllers/credentials/CredentialDefinitionController.ts b/packages/rest/src/controllers/credentials/CredentialDefinitionController.ts
@@ -34,7 +34,7 @@ export class CredentialDefinitionController {
     try {
       return await this.agent.ledger.getCredentialDefinition(credentialDefinitionId)
     } catch (error) {
-      if (error instanceof IndySdkError && isIndyError(error.cause, 'LedgerNotFound')) {
+      if (error instanceof LedgerNotFoundError) {
         throw new NotFoundError(
           `credential definition with credentialDefinitionId "${credentialDefinitionId}" not found.`
         )

diff --git a/packages/rest/src/controllers/credentials/SchemaController.ts b/packages/rest/src/controllers/credentials/SchemaController.ts
@@ -35,7 +35,7 @@ export class SchemaController {
     try {
       return await this.agent.ledger.getSchema(schemaId)
     } catch (error) {
-      if (error instanceof IndySdkError && isIndyError(error.cause, 'LedgerNotFound')) {
+      if (error instanceof LedgerNotFoundError) {
         throw new NotFoundError(`schema definition with schemaId "${schemaId}" not found.`)
       } else if (error instanceof LedgerError && error.cause instanceof IndySdkError) {
         if (isIndyError(error.cause.cause, 'LedgerInvalidTransaction')) {

diff --git a/packages/rest/tests/credentialDefinition.test.ts b/packages/rest/tests/credentialDefinition.test.ts
@@ -44,7 +44,7 @@ describe('CredentialDefinitionController', () => {
       expect(response.statusCode).toBe(400)
     })
 
-    test('should return 404 NotFound when schema not found', async () => {
+    test('should return 404 NotFound when credential definition not found', async () => {
       const response = await request(app).get(`/credential-definitions/WgWxqztrNooG92RXvxSTWv:3:CL:20:tag`)
       expect(response.statusCode).toBe(404)
     })