feat(rest): added outofband offer to credentialController #70
Conversation
Signed-off-by: janrtvld <jan@animo.id>
packages/rest/src/controllers/credentials/CredentialController.ts
Outdated
Show resolved
Hide resolved
packages/rest/src/controllers/credentials/CredentialController.ts
Outdated
Show resolved
Hide resolved
packages/rest/src/controllers/credentials/CredentialController.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: janrtvld <jan@animo.id>
Signed-off-by: janrtvld <jan@animo.id>
Signed-off-by: janrtvld <jan@animo.id>
|
|
||
| return { | ||
| message: `${this.agent.config.endpoints[0]}/?d_m=${JsonEncoder.toBase64URL( | ||
| credential.offerMessage.toJSON({ useLegacyDidSovPrefix: this.agent.config.useLegacyDidSovPrefix }) |
There was a problem hiding this comment.
Is the legacy did sov prefix also supported for the proof endpoint?
There was a problem hiding this comment.
I added it to the out of band proof request too. Also cleaned up the code a little.
Signed-off-by: janrtvld <jan@animo.id>
Signed-off-by: janrtvld <jan@animo.id>
Signed-off-by: janrtvld <jan@animo.id>
Codecov Report
@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 85.43% 85.83% +0.40%
==========================================
Files 25 27 +2
Lines 453 466 +13
Branches 76 80 +4
==========================================
+ Hits 387 400 +13
Misses 66 66
Continue to review full report at Codecov.
|
Can't seem to find any issues. Also running with |
|
@janrtvld somehow the integration tests for node 14.x are hanging. Already tried to re-run. Could it be because of changes to this PR? |
|
Ok, trying again. Have you tried running in Node 14? |
|
It worked 🎉Let’s hope it doesn’t persist |
#69
Signed-off-by: janrtvld jan@animo.id