Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add indyError util for consistent error handling #134

Conversation

TimoGlastra
Copy link
Contributor

Adds indyError util for consistent error handling. As it can take a while before a new version of indy-sdk is released with the changes (hyperledger-archives/indy-sdk#2283), it takes inconsistencies between indy-sdk and rn-indy-sdk into account. This can be removed once indy-sdk updates

Related to AbsaOSS/rn-indy-sdk#24

Signed-off-by: Timo Glastra <timo@animo.id>
@TimoGlastra TimoGlastra requested a review from a team as a code owner November 12, 2020 11:47
@lgtm-com
Copy link

lgtm-com bot commented Nov 12, 2020

This pull request introduces 1 alert when merging 4c15dfe into 39b7dde - view on LGTM.com

new alerts:

  • 1 for Comparison with NaN

Signed-off-by: Timo Glastra <timo@animo.id>
Copy link
Contributor

@jakubkoci jakubkoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@TimoGlastra TimoGlastra merged commit ea69add into openwallet-foundation:master Nov 12, 2020
@TimoGlastra TimoGlastra deleted the consistent-indy-error-handling branch November 12, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants