Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed biometrics hang if user closed app while onboarding #468

Merged
merged 5 commits into from
Oct 6, 2022

Conversation

wadeking98
Copy link
Contributor

Signed-off-by: wadeking98 wkingnumber2@gmail.com

Summary of Changes

Previously if the user closed the app at the biometrics screen, then opened it again, they would get stuck on the splash screen after clicking continue. This was due to store.authentication.didAuthenticate being reset after the app gets reopened. Since didAuthenticate gets reset to false the agent is never initialized on the splash screen.

I changed the commitPIN functionality to set the user as authenticated if it is able to load the wallet secret. That way the user can close the app between the create PIN screen and the biometrics screen and still be considered authenticated by the app

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
  • Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
  • Updated documentation as needed for changed code and new or modified features;
  • Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

  • Read our contribution guide at least once; it will save you a few review cycles!
  • Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

Signed-off-by: wadeking98 <wkingnumber2@gmail.com>
@wadeking98 wadeking98 requested a review from a team as a code owner October 5, 2022 18:51
@jleach jleach merged commit fe9f4bc into openwallet-foundation:main Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants