fixed biometrics hang if user closed app while onboarding #468
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wadeking98 wkingnumber2@gmail.com
Summary of Changes
Previously if the user closed the app at the biometrics screen, then opened it again, they would get stuck on the splash screen after clicking continue. This was due to
store.authentication.didAuthenticate
being reset after the app gets reopened. SincedidAuthenticate
gets reset to false the agent is never initialized on the splash screen.I changed the commitPIN functionality to set the user as authenticated if it is able to load the wallet secret. That way the user can close the app between the create PIN screen and the biometrics screen and still be considered authenticated by the app
Related Issues
N/A
Pull Request Checklist
Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.
Signed-off-by
line (we use the DCO GitHub app to enforce this);If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
Pro Tip 🤓
PR template adapted from the Python attrs project.