[Update] Update to anoncreds-rs 0.2 #1213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
gmulhearn-anonyome
changed the title
|
@JamesKEbert thoughts on this? it gets us off the forked version of anoncreds-rs, but continues to lean into the potential longer-term issues with |
JamesKEbert
previously approved these changes
Jun 5, 2024
|
DCO check is broken as noted here--https://discord.com/channels/905194001349627914/1156961689971998782/1247613586638110894 |
|
@JamesKEbert ow yea yes please. didn't notice it was stuck 😅. i'll leave this PR unmerged for now |
Signed-off-by: George Mulhearn <gmulhearn@anonyome.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to migrate off of mirgee's fork and onto 0.2.0, we lose the following patches made on 0.2.0: hyperledger/anoncreds-rs@v0.2.0...mirgee:anoncreds-rs:refactor/public-api-changes.
However we can get around those public APIs being missing by using into our
Convertlayer: we can switch between the anoncreds-rs definition of RevocationStatusList, and our own anoncreds_types definition of RevocationStatusList. These definitions are exactly the same, and JSON de/serialize the exact same way, however our version has the public APIs we need. So we can switch between theirs and ours when we need to.Note that it is not perfectly efficient, as we are converting to JSON Value as an intermediate type (as we do for some other anoncreds types too), but this could potentially be cleaned up if we fully move to using the real types from anoncreds-rs crate.