Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return / accept strictly A2AMessages #137

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 14, 2020

Previously functions
vcx_credential_get_offers
vcx_get_credential
vcx_disclosed_proof_get_proof_msg
vcx_disclosed_proof_get_requests
returned Aries messages, but omitted @type field. This PR adds the @type to returned structures.

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get_credential_offer_messages returns Vec<CredentialOffer>
get_credential_offer_msg returns CredentialOffer
get_proof_request_messages returns Vec<PresentationRequest>

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas Patrik-Stas merged commit 676d793 into master Oct 15, 2020
@Patrik-Stas Patrik-Stas deleted the refactor/accept-output-a2a branch October 15, 2020 13:54
@Patrik-Stas Patrik-Stas mentioned this pull request Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants