Move agency_comm to separate crate

[mirgee]

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

[codecov-io]

Codecov Report

Merging #193 (7f2c53d) into master (a58d5dc) will increase coverage by 3.32%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #193      +/-   ##
==========================================
+ Coverage   57.47%   60.79%   +3.32%     
==========================================
  Files         156      147       -9     
  Lines       23907    19648    -4259     
  Branches     6217     4322    -1895     
==========================================
- Hits        13740    11945    -1795     
+ Misses       6219     4255    -1964     
+ Partials     3948     3448     -500     

Flag	Coverage Δ
integration	35.45% <22.28%> (+0.27%)	⬆️
unittests	53.49% <28.49%> (+2.79%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
agency_client/src/get_message.rs	85.71% <ø> (ø)
agency_client/src/payload.rs	0.00% <0.00%> (ø)
libvcx/src/api/connection.rs	39.87% <ø> (ø)
libvcx/src/api/credential.rs	33.56% <ø> (ø)
libvcx/src/api/disclosed_proof.rs	41.04% <ø> (ø)
libvcx/src/api/filters.rs	63.15% <ø> (ø)
libvcx/src/api/issuer_credential.rs	36.88% <ø> (ø)
libvcx/src/aries/handlers/connection/agent_info.rs	58.09% <0.00%> (-2.91%)	⬇️
libvcx/src/aries/handlers/connection/connection.rs	66.40% <ø> (ø)
libvcx/src/aries/messages/a2a/message_type.rs	77.41% <ø> (ø)
... and 67 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a58d5dc...7f2c53d. Read the comment docs.

[Patrik-Stas]

• cargo.toml has extra dependencies (tokio-threadpool, libloading, ... probably more)
• tests should be adjust not to work with with aries. for example we have test_update_agency_messages which first establishes aries connection - it was convenient, but it is not necessary to test the integration agency_comm/agency. We can create agent_connection in agency using the agency_comm interface, and we know how a message should be sent to this agent_connection.
• I see you had to move bunch of stuff from utils aries-vcx module. I think little bit of duplication can be alright, sometimes its better than to overengineer and make module out of everything. The problem I see with this is that these functions are causing VcxError to be brough in, which seem unnecessary. I think we should return something like AgencyError from agency, and then let consumer of agency_comm module to deal with those errors (in case of vcx-aries as consumer of agency_comm, perhaps convert these errors)
• Ultimately it would be good to get rid of agency_settings.rs so that a consumer of could create multiple agency_comm client instances.
• How about renaming agency_comm to agency_client?

[Patrik-Stas]

@mirgee we are on a good course with this, great job!