Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Rust edition2018, fix compile warnings #204

Merged
merged 4 commits into from
Nov 18, 2020
Merged

Conversation

Patrik-Stas
Copy link
Contributor

No description provided.

@Patrik-Stas Patrik-Stas force-pushed the rust/edition2018 branch 2 times, most recently from 0de28da to 9b5da3f Compare November 16, 2020 12:02
@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #204 (4450d17) into master (f06ba4c) will decrease coverage by 0.00%.
The diff coverage is 73.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
- Coverage   60.79%   60.79%   -0.01%     
==========================================
  Files         147      147              
  Lines       19648    19650       +2     
  Branches     4322     4322              
==========================================
+ Hits        11945    11946       +1     
- Misses       4255     4256       +1     
  Partials     3448     3448              
Flag Coverage Δ
integration 35.45% <63.04%> (+<0.01%) ⬆️
unittests 53.49% <37.26%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/api/filters.rs 63.15% <ø> (ø)
libvcx/src/api/logger.rs 11.11% <ø> (ø)
libvcx/src/api/proof.rs 52.73% <ø> (ø)
libvcx/src/api/return_types_u32.rs 64.06% <ø> (ø)
libvcx/src/aries/handlers/connection/agent_info.rs 58.09% <ø> (ø)
libvcx/src/aries/handlers/connection/connection.rs 66.40% <ø> (ø)
...aries/handlers/connection/invitee/state_machine.rs 71.78% <ø> (ø)
...ies/handlers/connection/invitee/states/complete.rs 86.00% <ø> (ø)
...ries/handlers/connection/invitee/states/invited.rs 55.55% <ø> (ø)
...c/aries/handlers/connection/invitee/states/null.rs 60.00% <ø> (ø)
... and 124 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f06ba4c...3cc15f7. Read the comment docs.

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the base branch from master to ci/remove-set-env November 17, 2020 09:00
@Patrik-Stas Patrik-Stas changed the title Rust/edition2018 Update to Rust edition2018, fix compile warnings Nov 17, 2020
Base automatically changed from ci/remove-set-env to master November 17, 2020 16:29
Copy link
Contributor

@mirgee mirgee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this 👍 , except for the conflicts I will have to go through - don't think it will be that bad, though

@mirgee mirgee merged commit 3dd89aa into master Nov 18, 2020
@mirgee mirgee deleted the rust/edition2018 branch November 18, 2020 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants