Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node wrapper eslint #232

Merged
merged 7 commits into from
Dec 11, 2020
Merged

Node wrapper eslint #232

merged 7 commits into from
Dec 11, 2020

Conversation

OoDeLally
Copy link
Contributor

@OoDeLally OoDeLally commented Dec 8, 2020

TsLint was dropped since obsolete. Replaced by Typescript Eslint. Setup the base config files.

Pascal Heitz added 3 commits December 8, 2020 19:00
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
@OoDeLally OoDeLally requested a review from a team as a code owner December 8, 2020 18:01
@OoDeLally OoDeLally changed the base branch from master to package-upgrade December 8, 2020 18:02
@OoDeLally OoDeLally marked this pull request as draft December 8, 2020 18:07
@codecov-io
Copy link

codecov-io commented Dec 8, 2020

Codecov Report

Merging #232 (29b6d50) into master (521462e) will decrease coverage by 5.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #232      +/-   ##
==========================================
- Coverage   57.69%   51.95%   -5.74%     
==========================================
  Files         149      148       -1     
  Lines       19902    18973     -929     
  Branches     4464     4327     -137     
==========================================
- Hits        11482     9858    -1624     
- Misses       5071     6051     +980     
+ Partials     3349     3064     -285     
Flag Coverage Δ
integration ?
unittests 51.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/libindy/utils/anoncreds.rs 21.49% <0.00%> (-59.16%) ⬇️
libvcx/src/libindy/utils/pool.rs 17.39% <0.00%> (-58.66%) ⬇️
libvcx/src/utils/plugins.rs 0.00% <0.00%> (-42.86%) ⬇️
libvcx/src/libindy/utils/ledger.rs 11.74% <0.00%> (-39.24%) ⬇️
libvcx/src/aries/mod.rs 1.04% <0.00%> (-30.77%) ⬇️
libvcx/src/utils/random.rs 75.00% <0.00%> (-25.00%) ⬇️
libvcx/src/utils/devsetup.rs 26.70% <0.00%> (-21.53%) ⬇️
libvcx/src/libindy/utils/payments.rs 42.98% <0.00%> (-21.15%) ⬇️
libvcx/src/libindy/proofs/verifier/verifier.rs 70.37% <0.00%> (-18.06%) ⬇️
...aries/handlers/proof_presentation/prover/prover.rs 57.79% <0.00%> (-17.32%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521462e...29b6d50. Read the comment docs.

Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be preferable to split into 2 PRs:

  1. update of FFI dependencies
  2. eslint/formatting one

As this way it's hard to see whether there were any changes related to FFI updates

@OoDeLally
Copy link
Contributor Author

It'd be preferable to split into 2 PRs:

  1. update of FFI dependencies
  2. eslint/formatting one

As this way it's hard to see whether there were any changes related to FFI updates

Interesting... I've originally created this PR against master, that's why you see these diff in the package.json.
But when I moved it against package-upgrade (to avoid exactly that), the diff in github doesnt change... 🤷

Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
@OoDeLally OoDeLally changed the base branch from package-upgrade to master December 10, 2020 15:03
@OoDeLally OoDeLally marked this pull request as ready for review December 10, 2020 15:04
Patrik-Stas
Patrik-Stas previously approved these changes Dec 10, 2020
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Pascal Heitz added 2 commits December 10, 2020 18:33
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
@Patrik-Stas Patrik-Stas merged commit 37bb2a1 into master Dec 11, 2020
@Patrik-Stas Patrik-Stas deleted the node-wrapper-eslint branch December 11, 2020 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants