-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node wrapper eslint #232
Node wrapper eslint #232
Conversation
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Codecov Report
@@ Coverage Diff @@
## master #232 +/- ##
==========================================
- Coverage 57.69% 51.95% -5.74%
==========================================
Files 149 148 -1
Lines 19902 18973 -929
Branches 4464 4327 -137
==========================================
- Hits 11482 9858 -1624
- Misses 5071 6051 +980
+ Partials 3349 3064 -285
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It'd be preferable to split into 2 PRs:
- update of FFI dependencies
- eslint/formatting one
As this way it's hard to see whether there were any changes related to FFI updates
Interesting... I've originally created this PR against |
ed9c7d9
to
859c522
Compare
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
ca74869
to
f6ec854
Compare
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
TsLint was dropped since obsolete. Replaced by Typescript Eslint. Setup the base config files.