Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node wrapper eslint manual lint #235

Merged
merged 4 commits into from
Dec 14, 2020
Merged

Conversation

OoDeLally
Copy link
Contributor

@OoDeLally OoDeLally commented Dec 14, 2020

Only b124c15 is important to review attentively. The other two commits are cosmetics only.

@OoDeLally OoDeLally requested a review from a team as a code owner December 14, 2020 10:51
Pascal Heitz added 3 commits December 14, 2020 11:51
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
Signed-off-by: Pascal Heitz <pascal.heitz@absa.africa>
@codecov-io
Copy link

Codecov Report

Merging #235 (57004b0) into master (567ed0a) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   57.69%   57.69%           
=======================================
  Files         149      149           
  Lines       19902    19902           
  Branches     4464     4464           
=======================================
  Hits        11482    11482           
  Misses       5071     5071           
  Partials     3349     3349           
Flag Coverage Δ
integration 26.14% <ø> (ø)
unittests 51.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 567ed0a...57004b0. Read the comment docs.

@Patrik-Stas Patrik-Stas merged commit 824a6b2 into master Dec 14, 2020
@Patrik-Stas Patrik-Stas deleted the node-wrapper-eslint-manual-lint branch December 14, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants