Node wrapper eslint fix anys

[OoDeLally]

These changes require a bit of attention, since they are not merely cosmetics

[codecov-io]

Codecov Report

Merging #237 (fe9895b) into master (824a6b2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   57.69%   57.69%           
=======================================
  Files         149      149           
  Lines       19902    19902           
  Branches     4464     4464           
=======================================
  Hits        11482    11482           
  Misses       5071     5071           
  Partials     3349     3349           

Flag	Coverage Δ
integration	26.14% <ø> (ø)
unittests	51.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 824a6b2...fe9895b. Read the comment docs.

[Patrik-Stas]

Why is the constraint removed? I think it was quite useful to protect from inconsistency / typos between IFFIEntryPoint and FFIConfiguration

[Patrik-Stas]

Ref type is complex structure according to its definition

export interface Type {
    /** The size in bytes required to hold this datatype. */
    size: number;
    /** The current level of indirection of the buffer. */
    indirection: number;
    /** To invoke when `ref.get` is invoked on a buffer of this type. */
    get(buffer: Buffer, offset: number): any;
    /** To invoke when `ref.set` is invoked on a buffer of this type. */
    set(buffer: Buffer, offset: number, value: any): void;
    /** The name to use during debugging for this datatype. */
    name?: string;
    /** The alignment of this datatype when placed inside a struct. */
    alignment?: number;
}

whereas rust function looks like this

pub extern fn vcx_wallet_sign_with_address(command_handle: CommandHandle,
                                           payment_address: *const c_char,
                                           message_raw: *const u8,
                                           message_len: u32,
                                           cb: Option<extern fn(xcommand_handle: CommandHandle, err: u32,
                                                                signature: *const u8, signature_len: u32)>) -> u32 {

where signature: *const u8 in callback maps to detailsPtr and it's just u8 pointer.

We don't use signWithAddress now, probably not even testing it so I don't know if your change actually works or not, but doesn't seem correct to me.