Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect evaluation whether PR is prerelease #244

Merged
merged 1 commit into from
Dec 21, 2020

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Dec 21, 2020

2 changes:

  • previously every non-master PR was marked as pre-release, even if it did not contain pre-release label. This is because github expression are not directly understood by bash.
  • pull request with bumped version is not understood as pre-release. The only way to pre-release is by assigning pre-release label

@Patrik-Stas Patrik-Stas requested a review from a team as a code owner December 21, 2020 09:02
@Patrik-Stas Patrik-Stas force-pushed the ci/fix-is-prerelease-evaluation branch from 3b964f2 to a2ce8be Compare December 21, 2020 09:02
@Patrik-Stas Patrik-Stas force-pushed the ci/fix-is-prerelease-evaluation branch 4 times, most recently from e9f249a to 9f1cbf6 Compare December 21, 2020 09:21
@codecov-io
Copy link

codecov-io commented Dec 21, 2020

Codecov Report

Merging #244 (a2ce8be) into master (71237f3) will decrease coverage by 5.71%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #244      +/-   ##
==========================================
- Coverage   57.38%   51.66%   -5.72%     
==========================================
  Files         149      148       -1     
  Lines       20009    19080     -929     
  Branches     4502     4365     -137     
==========================================
- Hits        11482     9858    -1624     
- Misses       5178     6158     +980     
+ Partials     3349     3064     -285     
Flag Coverage Δ
integration ?
unittests 51.66% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/libindy/utils/anoncreds.rs 21.49% <0.00%> (-59.16%) ⬇️
libvcx/src/libindy/utils/pool.rs 17.39% <0.00%> (-58.66%) ⬇️
libvcx/src/utils/plugins.rs 0.00% <0.00%> (-42.86%) ⬇️
libvcx/src/libindy/utils/ledger.rs 11.74% <0.00%> (-39.24%) ⬇️
libvcx/src/aries/mod.rs 1.04% <0.00%> (-30.77%) ⬇️
libvcx/src/utils/random.rs 75.00% <0.00%> (-25.00%) ⬇️
libvcx/src/utils/devsetup.rs 26.70% <0.00%> (-21.53%) ⬇️
libvcx/src/libindy/utils/payments.rs 42.98% <0.00%> (-21.15%) ⬇️
libvcx/src/libindy/proofs/verifier/verifier.rs 70.37% <0.00%> (-18.06%) ⬇️
...aries/handlers/proof_presentation/prover/prover.rs 57.79% <0.00%> (-17.32%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71237f3...a323eaa. Read the comment docs.

@Patrik-Stas Patrik-Stas added the ci label Dec 21, 2020
@Patrik-Stas Patrik-Stas force-pushed the ci/fix-is-prerelease-evaluation branch 3 times, most recently from 455a7a6 to 3aee509 Compare December 21, 2020 10:00
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas force-pushed the ci/fix-is-prerelease-evaluation branch from 3aee509 to a323eaa Compare December 21, 2020 10:25
@Patrik-Stas Patrik-Stas merged commit e3bdaf1 into master Dec 21, 2020
@Patrik-Stas Patrik-Stas deleted the ci/fix-is-prerelease-evaluation branch December 21, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants