Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix occasionally failing integration test. #310

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jun 29, 2021

The test test_create_credential_works_twice occasionally fails in CI - never run into this issue locally. The CI failure of this test is such that the second of creating the same credential definition passes, while it's expected to fail. I think the reason is that probably on the second attempt, the created credential definition is not yet fully propagated through the pool, and so it appears like the credential definition doesn't exist yet.
This PR add timeout into the test between first and second attempt to create the same cred. definition.

Signed-off-by: Patrik Stas patrik.stas@absa.africa

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner June 29, 2021 08:10
@Patrik-Stas Patrik-Stas added the ci label Jun 29, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #310 (9498698) into master (42e8038) will decrease coverage by 4.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
- Coverage   49.72%   45.55%   -4.18%     
==========================================
  Files         155      153       -2     
  Lines       19639    18783     -856     
  Branches     6202     5888     -314     
==========================================
- Hits         9766     8556    -1210     
- Misses       5072     6114    +1042     
+ Partials     4801     4113     -688     
Flag Coverage Δ
integration ?
unittests 45.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvcx/src/credential_def.rs 36.47% <ø> (-11.87%) ⬇️
libvcx/src/libindy/utils/pool.rs 14.58% <0.00%> (-52.42%) ⬇️
libvcx/src/libindy/utils/anoncreds.rs 17.81% <0.00%> (-47.02%) ⬇️
libvcx/src/utils/plugins.rs 0.00% <0.00%> (-33.34%) ⬇️
libvcx/src/libindy/utils/ledger.rs 12.00% <0.00%> (-27.24%) ⬇️
libvcx/src/utils/random.rs 75.00% <0.00%> (-25.00%) ⬇️
libvcx/src/utils/devsetup.rs 41.63% <0.00%> (-21.04%) ⬇️
libvcx/src/init.rs 25.80% <0.00%> (-20.97%) ⬇️
libvcx/src/utils/devsetup_agent.rs 0.00% <0.00%> (-20.33%) ⬇️
libvcx/src/libindy/utils/payments.rs 38.88% <0.00%> (-13.20%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42e8038...9498698. Read the comment docs.

@Patrik-Stas Patrik-Stas requested a review from mirgee June 29, 2021 10:12
@mirgee mirgee added hotfix High priority fixes of unexpected issues tests labels Jun 29, 2021
@mirgee mirgee merged commit ad5353d into master Jun 29, 2021
@mirgee mirgee deleted the fix/failing-creddef-test branch June 29, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci hotfix High priority fixes of unexpected issues tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants