Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Out of Band protocol #344

Merged
merged 20 commits into from
Sep 8, 2021
Merged

Out of Band protocol #344

merged 20 commits into from
Sep 8, 2021

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Sep 3, 2021

No description provided.

@mirgee
Remove unused service module, split service into enum
c9f06f1 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Move service to separate module
b121edb 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Rename FullService to ServiceResolvable
2f50d37 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Custom ParialEq implementation
b408141 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
WIP
31ddea4 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee changed the base branch from main to refactor/service September 3, 2021 14:51
@mirgee mirgee added the enhancement New feature or request label Sep 3, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 3, 2021 •
edited
Loading

Codecov Report

Merging #344 (95e5411) into main (b6fdb6f) will decrease coverage by 3.66%.
The diff coverage is 5.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
- Coverage   49.53%   45.87%   -3.67%     
==========================================
  Files         160      103      -57     
  Lines       17286     8271    -9015     
  Branches     3851     2075    -1776     
==========================================
- Hits         8562     3794    -4768     
+ Misses       6039     3083    -2956     
+ Partials     2685     1394    -1291
Flag Coverage Δ
integration ?
unittests 45.87% <5.26%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/error.rs 0.00% <ø> (ø)
aries_vcx/src/handlers/connection/cloud_agent.rs 0.00% <0.00%> (-46.08%) ⬇️
aries_vcx/src/handlers/connection/connection.rs 0.00% <0.00%> (-42.68%) ⬇️
...x/src/handlers/connection/invitee/state_machine.rs 0.00% <0.00%> (-36.34%) ⬇️
...src/handlers/connection/invitee/states/complete.rs 0.00% <0.00%> (-39.48%) ⬇️
.../src/handlers/connection/invitee/states/invited.rs 0.00% <0.00%> (-40.00%) ⬇️
...vcx/src/handlers/connection/invitee/states/null.rs 0.00% <0.00%> (-50.00%) ⬇️
...rc/handlers/connection/invitee/states/requested.rs 0.00% <0.00%> (-45.46%) ⬇️
...rc/handlers/connection/invitee/states/responded.rs 0.00% <0.00%> (-37.50%) ⬇️
...x/src/handlers/connection/inviter/state_machine.rs 0.00% <0.00%> (-40.89%) ⬇️
... and 130 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6fdb6f...95e5411. Read the comment docs.

@mirgee
Test: establish connection via oob
afe9b95 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Store bootstrap agent, match connection with OOB message
823e414 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Resolve service
43c83dd 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Include a2a message in oob message in test
8f07083 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Fix service unit test
fe8dd8b 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Return an option from connection_exists
dc4cc4c 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Base automatically changed from refactor/service to main September 7, 2021 10:49
@mirgee
Set pthid
186ee5d 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Merge branch 'main' into feature/out-of-band
cb2a2e9 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>

# Conflicts:
#	aries_vcx/src/messages/connection/invite.rs
#	aries_vcx/src/messages/connection/service.rs
@mirgee
Append handshake protocol
6e39fd3 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Patrik-Stas
Patrik-Stas requested changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@Patrik-Stas Patrik-Stas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments

@mirgee
Address a few comments
394ca0d 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Exchange messages
c14f646 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Deduplicate connection progress in test
5d957eb 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Test connection_exists picks the correct one
d723b47 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Skip did resolution if ids match
ceccfd0 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee
Fix typo
95e5411 
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee changed the title WIP: Out of Band protocol Out of Band protocol Sep 8, 2021
@mirgee mirgee marked this pull request as ready for review September 8, 2021 11:08
@mirgee mirgee requested a review from a team as a code owner September 8, 2021 11:08
@Patrik-Stas Patrik-Stas merged commit b3b6ab5 into main Sep 8, 2021
@Patrik-Stas Patrik-Stas deleted the feature/out-of-band branch September 8, 2021 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Patrik-Stas Patrik-Stas Patrik-Stas approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mirgee @codecov-commenter @Patrik-Stas