Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. SM refactors + remove all warnings #374

Merged
merged 8 commits into from
Nov 1, 2021
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Oct 29, 2021

Add new initial state for issuer (to allow downloading proposal via update_state), use destructuring in connection SMs, rename inviter's / invitee'sNullState to InitialState, fix all compiler warnings for all features and tests, store thread id on SM level in connection SMs as well.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee requested a review from a team as a code owner October 29, 2021 14:26
…of discarding it

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee changed the title SM initial states + remove all warnings Misc. SM refactors + remove all warnings Oct 29, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 29, 2021

Codecov Report

Merging #374 (a595002) into main (845ed41) will decrease coverage by 19.55%.
The diff coverage is 54.73%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #374       +/-   ##
===========================================
- Coverage   66.20%   46.65%   -19.56%     
===========================================
  Files         154      154               
  Lines       14593    13235     -1358     
  Branches     2873     2690      -183     
===========================================
- Hits         9662     6175     -3487     
- Misses       2602     5536     +2934     
+ Partials     2329     1524      -805     
Flag Coverage Δ
integration-aries-vcx ?
unittests-agency-client 22.51% <ø> (ø)
unittests-aries-vcx 48.85% <54.73%> (+0.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agency_client/src/httpclient.rs 0.00% <ø> (ø)
...rc/handlers/connection/inviter/states/requested.rs 33.33% <0.00%> (ø)
aries_vcx/src/handlers/issuance/holder/holder.rs 42.30% <0.00%> (-16.73%) ⬇️
...vcx/src/handlers/issuance/issuer/states/initial.rs 0.00% <0.00%> (-68.97%) ⬇️
...ies_vcx/src/handlers/issuance/issuer/states/mod.rs 100.00% <ø> (ø)
aries_vcx/src/handlers/mod.rs 0.00% <0.00%> (-14.29%) ⬇️
...x/src/handlers/proof_presentation/prover/prover.rs 15.66% <ø> (-57.20%) ⬇️
...n/prover/states/presentation_preparation_failed.rs 60.00% <ø> (ø)
.../verifier/states/presentation_proposal_received.rs 87.50% <ø> (ø)
...c/handlers/proof_presentation/verifier/verifier.rs 34.48% <ø> (-29.32%) ⬇️
... and 111 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 845ed41...a595002. Read the comment docs.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@Patrik-Stas Patrik-Stas merged commit d76d6fe into main Nov 1, 2021
@Patrik-Stas Patrik-Stas deleted the refactor/state-machines branch November 1, 2021 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants