Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config builder methods #384

Merged
merged 2 commits into from
Nov 24, 2021
Merged

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Nov 22, 2021

Makes initialization using Rust API a little more succint.

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee requested a review from a team as a code owner November 22, 2021 19:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2021

Codecov Report

Merging #384 (accef19) into main (3ab9ebc) will decrease coverage by 0.24%.
The diff coverage is 0.00%.

❗ Current head accef19 differs from pull request most recent head 106bfc9. Consider uploading reports for the commit 106bfc9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #384      +/-   ##
==========================================
- Coverage   66.39%   66.14%   -0.25%     
==========================================
  Files         153      153              
  Lines       14454    14508      +54     
  Branches     2861     2861              
==========================================
  Hits         9597     9597              
- Misses       2535     2589      +54     
  Partials     2322     2322              
Flag Coverage Δ
integration-aries-vcx 53.02% <0.00%> (-0.27%) ⬇️
unittests-agency-client 22.51% <ø> (ø)
unittests-aries-vcx 48.40% <0.00%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/init.rs 31.88% <0.00%> (-6.72%) ⬇️
aries_vcx/src/libindy/utils/wallet.rs 29.61% <0.00%> (-3.44%) ⬇️
aries_vcx/src/utils/provision.rs 34.04% <0.00%> (-15.96%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ab9ebc...106bfc9. Read the comment docs.

Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
@mirgee mirgee force-pushed the feature/config-builder-methods branch from 65066d4 to 106bfc9 Compare November 24, 2021 11:50
@mirgee mirgee added the enhancement New feature or request label Nov 24, 2021
@Patrik-Stas Patrik-Stas merged commit becb5b9 into main Nov 24, 2021
@Patrik-Stas Patrik-Stas deleted the feature/config-builder-methods branch November 24, 2021 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants