Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downgrade reqwest #387

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Downgrade reqwest #387

merged 1 commit into from
Nov 24, 2021

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Nov 23, 2021

Fixes issue encountered in higher versions of reqwest where dropping a nested runtime results in a panic:

'Cannot drop a runtime in a context where blocking is not allowed. This happens when a runtime is dropped from within an asynchronous context.'

Signed-off-by: Miroslav Kovar miroslavkovar@protonmail.com

@mirgee mirgee requested a review from a team as a code owner November 23, 2021 13:19
@mirgee mirgee added the hotfix High priority fixes of unexpected issues label Nov 23, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #387 (d9e747f) into main (3ab9ebc) will not change coverage.
The diff coverage is 0.00%.

❗ Current head d9e747f differs from pull request most recent head f23de72. Consider uploading reports for the commit f23de72 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #387   +/-   ##
=======================================
  Coverage   66.39%   66.39%           
=======================================
  Files         153      153           
  Lines       14454    14454           
  Branches     2861     2861           
=======================================
  Hits         9597     9597           
  Misses       2535     2535           
  Partials     2322     2322           
Flag Coverage Δ
integration-aries-vcx 53.28% <ø> (-0.01%) ⬇️
unittests-agency-client 22.51% <0.00%> (ø)
unittests-aries-vcx 48.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agency_client/src/httpclient.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update becb5b9...f23de72. Read the comment docs.

Patrik-Stas
Patrik-Stas previously approved these changes Nov 24, 2021
Signed-off-by: Miroslav Kovar <miroslavkovar@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotfix High priority fixes of unexpected issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants