Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/testing #515

Merged
merged 2 commits into from Jul 20, 2022
Merged

Refactor/testing #515

merged 2 commits into from Jul 20, 2022

Conversation

Patrik-Stas
Copy link
Contributor

No description provided.

Base automatically changed from refactor/agency-client-instance to refactor/remove-try-from July 19, 2022 13:44
@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #515 (7c27607) into main (88bf722) will decrease coverage by 6.36%.
The diff coverage is 58.02%.

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   54.75%   48.39%   -6.37%     
==========================================
  Files         163      163              
  Lines       14649    11814    -2835     
  Branches     4072     2502    -1570     
==========================================
- Hits         8021     5717    -2304     
- Misses       2373     3940    +1567     
+ Partials     4255     2157    -2098     
Flag Coverage Δ
integration-aries-vcx ?
unittests-agency-client 23.98% <66.66%> (ø)
unittests-aries-vcx 50.66% <57.33%> (+0.38%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agency_client/src/agency_client.rs 23.91% <ø> (ø)
agency_client/src/testing/mocking.rs 43.05% <0.00%> (ø)
...ries_vcx/src/handlers/proof_presentation/prover.rs 15.49% <0.00%> (-43.69%) ⬇️
aries_vcx/src/init.rs 14.00% <0.00%> (-16.65%) ⬇️
...s_vcx/src/libindy/proofs/prover/prover_internal.rs 73.60% <0.00%> (-4.27%) ⬇️
aries_vcx/src/libindy/utils/ledger.rs 11.55% <ø> (-19.88%) ⬇️
aries_vcx/src/libindy/utils/wallet.rs 25.15% <ø> (-7.01%) ⬇️
aries_vcx/tests/utils/devsetup_agent.rs 0.00% <0.00%> (-46.32%) ⬇️
aries_vcx/src/libindy/utils/anoncreds.rs 15.13% <44.44%> (-34.87%) ⬇️
aries_vcx/src/utils/devsetup.rs 53.10% <68.57%> (-17.21%) ⬇️
... and 81 more

@Patrik-Stas Patrik-Stas changed the base branch from refactor/remove-try-from to main July 19, 2022 14:06
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas marked this pull request as ready for review July 19, 2022 15:24
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner July 19, 2022 15:24
@Patrik-Stas Patrik-Stas requested a review from mirgee July 19, 2022 15:27
aries_vcx/src/utils/devsetup.rs Outdated Show resolved Hide resolved
aries_vcx/src/utils/devsetup.rs Show resolved Hide resolved
aries_vcx/src/utils/devsetup.rs Show resolved Hide resolved
aries_vcx/src/libindy/utils/anoncreds.rs Outdated Show resolved Hide resolved
aries_vcx/src/libindy/utils/anoncreds.rs Outdated Show resolved Hide resolved
aries_vcx/src/libindy/utils/anoncreds.rs Outdated Show resolved Hide resolved
aries_vcx/src/libindy/utils/anoncreds.rs Show resolved Hide resolved
aries_vcx/src/settings.rs Outdated Show resolved Hide resolved
aries_vcx/src/settings.rs Outdated Show resolved Hide resolved
aries_vcx/src/settings.rs Outdated Show resolved Hide resolved
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas requested a review from mirgee July 20, 2022 12:37
@mirgee mirgee merged commit 24701ca into main Jul 20, 2022
@mirgee mirgee deleted the refactor/testing branch July 20, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants