Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize files, remove access to global data from aries-vcx src #517

Merged
merged 8 commits into from Jul 21, 2022

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jul 19, 2022

  • Create new /global module for everything related to global storage on aries-vcx level. The goal is for this module to not exist, eventually. Globals should be moved to libvcx
  • Remove any get_main_wallet_handle calls in aries-vcx, instead call this from libvcx and inject into aries-vcx calls
  • Same for get_main_agency_client
  • aries-vcx code now does not ever access global data (agency_client or wallet_handle)

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022

Codecov Report

Merging #517 (72f676c) into main (24701ca) will increase coverage by 0.20%.
The diff coverage is 28.02%.

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
+ Coverage   54.77%   54.97%   +0.20%     
==========================================
  Files         163      167       +4     
  Lines       14641    14629      -12     
  Branches     4076     4061      -15     
==========================================
+ Hits         8019     8042      +23     
+ Misses       2361     2344      -17     
+ Partials     4261     4243      -18     
Flag Coverage Δ
integration-aries-vcx 42.06% <26.28%> (+0.49%) ⬆️
unittests-agency-client 23.59% <44.82%> (-0.39%) ⬇️
unittests-aries-vcx 50.79% <26.68%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
agency_client/src/api/downloaded_message.rs 0.00% <0.00%> (ø)
agency_client/src/api/onboarding.rs 0.00% <0.00%> (ø)
agency_client/src/utils/libindy/crypto.rs 26.66% <0.00%> (ø)
aries_vcx/src/handlers/issuance/holder.rs 46.42% <0.00%> (ø)
aries_vcx/src/handlers/issuance/issuer.rs 49.19% <0.00%> (ø)
aries_vcx/src/handlers/out_of_band/receiver.rs 34.28% <0.00%> (ø)
...ries_vcx/src/handlers/proof_presentation/prover.rs 58.71% <0.00%> (ø)
...es_vcx/src/handlers/proof_presentation/verifier.rs 47.93% <0.00%> (ø)
.../src/libindy/credential_def/revocation_registry.rs 47.67% <0.00%> (ø)
...s_vcx/src/libindy/proofs/prover/prover_internal.rs 77.09% <0.00%> (ø)
... and 73 more

@Patrik-Stas Patrik-Stas marked this pull request as ready for review July 19, 2022 18:36
@Patrik-Stas Patrik-Stas requested a review from a team as a code owner July 19, 2022 18:36
@Patrik-Stas Patrik-Stas requested a review from mirgee July 19, 2022 18:36
@Patrik-Stas Patrik-Stas changed the title Reorganize files to separate global data based APIs Reorganize files, pull access to global variables up the stack Jul 20, 2022
Base automatically changed from refactor/testing to main July 20, 2022 13:07
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title Reorganize files, pull access to global variables up the stack Reorganize files, remove access to global data from aries-vcx src Jul 21, 2022
@mirgee mirgee merged commit 2948c2a into main Jul 21, 2022
@mirgee mirgee deleted the refactor/aries-vcx-reorg branch July 21, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants