New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize files, remove access to global data from aries-vcx src #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patrik-Stas
force-pushed
the
refactor/aries-vcx-reorg
branch
from
July 19, 2022 16:23
c60c00a
to
e9cce1d
Compare
Codecov Report
@@ Coverage Diff @@
## main #517 +/- ##
==========================================
+ Coverage 54.77% 54.97% +0.20%
==========================================
Files 163 167 +4
Lines 14641 14629 -12
Branches 4076 4061 -15
==========================================
+ Hits 8019 8042 +23
+ Misses 2361 2344 -17
+ Partials 4261 4243 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Patrik-Stas
force-pushed
the
refactor/aries-vcx-reorg
branch
from
July 19, 2022 22:43
158b037
to
ad6d329
Compare
Patrik-Stas
changed the title
Reorganize files to separate global data based APIs
Reorganize files, pull access to global variables up the stack
Jul 20, 2022
Patrik-Stas
force-pushed
the
refactor/aries-vcx-reorg
branch
from
July 20, 2022 12:53
ad6d329
to
d0441ca
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
refactor/aries-vcx-reorg
branch
from
July 20, 2022 14:16
d0441ca
to
353e5d4
Compare
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
changed the title
Reorganize files, pull access to global variables up the stack
Reorganize files, remove access to global data from aries-vcx src
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/global
module for everything related to global storage onaries-vcx
level. The goal is for this module to not exist, eventually. Globals should be moved to libvcxget_main_wallet_handle
calls inaries-vcx
, instead call this fromlibvcx
and inject into aries-vcx callsget_main_agency_client
aries-vcx
code now does not ever access global data (agency_client or wallet_handle)Signed-off-by: Patrik Stas patrik.stas@absa.africa