Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wallet_handle injectable when creating connection #525

Merged
merged 1 commit into from Jul 27, 2022

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Jul 25, 2022

  • Make wallet_handle injectable in all functions for Connection. This will be needed when building agency-less Connection implementation
  • Delete commented code which was originally trying to retrieve messages from bootstrap agent, but getting this code restored is nowhere near priority, hence deleting

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@Patrik-Stas Patrik-Stas requested a review from a team as a code owner July 25, 2022 21:41
Base automatically changed from tests/reorg-2 to main July 26, 2022 07:23
@Patrik-Stas Patrik-Stas force-pushed the connection/inject-wallet branch 2 times, most recently from 4bb754b to 5f39a43 Compare July 26, 2022 09:50
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

Codecov Report

Merging #525 (74f3959) into main (9a59824) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #525   +/-   ##
=======================================
  Coverage   54.99%   54.99%           
=======================================
  Files         168      168           
  Lines       14588    14588           
  Branches     4031     4031           
=======================================
  Hits         8023     8023           
  Misses       2357     2357           
  Partials     4208     4208           
Flag Coverage Δ
integration-aries-vcx 42.85% <0.00%> (ø)
unittests-agency-client 23.61% <ø> (ø)
unittests-aries-vcx 51.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/connection/connection.rs 52.58% <0.00%> (ø)
aries_vcx/src/handlers/out_of_band/receiver.rs 34.28% <0.00%> (ø)
aries_vcx/tests/utils/devsetup_agent.rs 50.15% <0.00%> (ø)
aries_vcx/tests/utils/scenarios.rs 50.09% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Patrik-Stas Patrik-Stas requested a review from mirgee July 27, 2022 12:32
@mirgee mirgee merged commit 08395ba into main Jul 27, 2022
@mirgee mirgee deleted the connection/inject-wallet branch July 27, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants