Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle did:sov service omitting routing_keys attribute #676

Merged
merged 3 commits into from
Dec 4, 2022

Conversation

guijd3p
Copy link
Contributor

@guijd3p guijd3p commented Dec 1, 2022

when performing a test with acapy a routing_keys problem was discovered, it generates an empty ledger.

@guijd3p guijd3p added the bugfix label Dec 1, 2022
@guijd3p guijd3p requested a review from a team as a code owner December 1, 2022 19:18
@guijd3p guijd3p self-assigned this Dec 1, 2022
@Patrik-Stas
Copy link
Contributor

Awesome, great to hear you've tested with acapy :-)

Yeah in general .unwrap() ideally shouldn't exist in the codebase (expect for tests), I've missed this in the review.

While we are at it, if you want to earn some bonus points, it'd be cool if you'd add test which test which would have catched the problematic scenario (eg routing_keys missing).

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #676 (d65cea7) into main (27411f0) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #676      +/-   ##
==========================================
- Coverage   63.85%   63.84%   -0.01%     
==========================================
  Files         214      214              
  Lines       21000    21000              
  Branches     4703     4701       -2     
==========================================
- Hits        13409    13408       -1     
  Misses       3843     3843              
- Partials     3748     3749       +1     
Flag Coverage Δ
unittests-aries-vcx 63.64% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/indy/ledger/transactions.rs 56.39% <100.00%> (ø)
...vcx/src/protocols/issuance/issuer/state_machine.rs 69.32% <0.00%> (-0.13%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Patrik-Stas
Patrik-Stas previously approved these changes Dec 1, 2022
@Patrik-Stas Patrik-Stas changed the title another agents no write routing_keys, in this case is none. Handle did:sov service omitting routing_keys attribute Dec 4, 2022
@Patrik-Stas Patrik-Stas merged commit 4ebb497 into main Dec 4, 2022
@Patrik-Stas Patrik-Stas deleted the 609-adhere-to-didsov-method-spec_bug branch December 4, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants