Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CredxAnoncreds verifier functionality support #708

Merged
merged 9 commits into from Jan 13, 2023
Merged

Conversation

gmulhearn
Copy link
Contributor

@gmulhearn gmulhearn commented Dec 23, 2022

#699 Implements credx verifier method and tests

  • Add new error ProofRejected to map to credx and vdrtools errors
  • minor fix to logging in setupprofile
  • changed tests as possible to use a dynamic profile (not locked to indy) for verifier functionality
  • ^ this meant using holder_setup profile, after the work for credx issuer APIs are complete, ALL tests should be able to use SetupProfile::run rather than SetupProfile::run_indy

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@gmulhearn gmulhearn changed the title Draft: Partial of #699 - credx verifier support Draft: CredxAnoncreds verifier functionality support Dec 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2022

Codecov Report

Merging #708 (d9915df) into main (eb788cd) will decrease coverage by 19.09%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##             main     #708       +/-   ##
===========================================
- Coverage   64.12%   45.03%   -19.10%     
===========================================
  Files         245      243        -2     
  Lines       22923    17723     -5200     
  Branches     5061     3454     -1607     
===========================================
- Hits        14700     7981     -6719     
- Misses       4096     7395     +3299     
+ Partials     4127     2347     -1780     
Flag Coverage Δ
unittests-aries-vcx 45.03% <0.00%> (-18.96%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/common/proofs/verifier/verifier.rs 64.10% <ø> (-19.85%) ⬇️
aries_vcx/src/errors/error.rs 40.54% <ø> (-2.71%) ⬇️
aries_vcx/src/errors/mapping_credx.rs 0.00% <0.00%> (-27.28%) ⬇️
aries_vcx/src/errors/mapping_vdrtools.rs 23.52% <0.00%> (-15.87%) ⬇️
aries_vcx/src/plugins/anoncreds/credx_anoncreds.rs 10.64% <0.00%> (-53.72%) ⬇️
aries_vcx/src/utils/devsetup.rs 60.11% <ø> (-13.63%) ⬇️
...tocols/proof_presentation/prover/states/initial.rs 0.00% <0.00%> (-100.00%) ⬇️
...cols/proof_presentation/verifier/states/initial.rs 0.00% <0.00%> (-100.00%) ⬇️
aries_vcx/src/handlers/discovery/mod.rs 0.00% <0.00%> (-93.94%) ⬇️
aries_vcx/tests/utils/scenarios.rs 0.00% <0.00%> (-80.47%) ⬇️
... and 133 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@gmulhearn gmulhearn changed the title Draft: CredxAnoncreds verifier functionality support CredxAnoncreds verifier functionality support Jan 12, 2023
Signed-off-by: gmulhearn <gmulhearn@proton.me>
@gmulhearn gmulhearn marked this pull request as ready for review January 12, 2023 08:39
@mirgee mirgee merged commit 4e4f02a into main Jan 13, 2023
@mirgee mirgee deleted the 699-credx-verifier branch January 13, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants