Remove unnecessary vdrtools code #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Patrik-Stas
force-pushed
the
vdrtools/cleanup
branch
from
0d86dbc
to
9451562
Compare
Codecov Report
@@ Coverage Diff @@
## main #736 +/- ##
===========================================
+ Coverage 29.73% 46.73% +16.99%
===========================================
Files 369 364 -5
Lines 31397 32547 +1150
Branches 6407 6981 +574
===========================================
+ Hits 9336 15210 +5874
+ Misses 19305 12791 -6514
- Partials 2756 4546 +1790
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mirgee
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delete directories
tests- these were based on rust wrapper and not functional for quite a while in the forkrpm,debian- we don't distribute vdrtoolssrc/api- c callable functions, we don't call vdrtools over ffi so this can goinclude- c headers, we don't deal with ffici,benchesMoved documentation from
src/apito respective functions in controller layer. This was done easily as functions insrc/apimapped always 1:1 on a function in controller / service layer.Some additional cleanups of of code related to ffi