Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose nonmediated connection in node wrapper #738

Merged
merged 11 commits into from Jan 25, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Jan 19, 2023

Signed-off-by: Miroslav Kovar miroslav.kovar@absa.africa

@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Merging #738 (9885ae6) into main (06aa3d6) will increase coverage by 0.00%.
The diff coverage is 36.36%.

@@           Coverage Diff           @@
##             main     #738   +/-   ##
=======================================
  Coverage   54.73%   54.73%           
=======================================
  Files         363      363           
  Lines       37119    37122    +3     
  Branches     8091     8089    -2     
=======================================
+ Hits        20317    20319    +2     
- Misses      10829    10832    +3     
+ Partials     5973     5971    -2     
Flag Coverage Δ
unittests-aries-vcx 54.63% <36.36%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/handlers/connection/connection.rs 58.17% <36.36%> (-0.43%) ⬇️
libvdrtools/src/services/pool/networker.rs 75.51% <0.00%> (+0.40%) ⬆️
libvdrtools/src/controllers/non_secrets.rs 47.80% <0.00%> (+0.48%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mirgee mirgee marked this pull request as draft January 19, 2023 20:32
@mirgee mirgee force-pushed the wrappers/expose-nonmediated-connection branch 4 times, most recently from 39e92ad to 85cb095 Compare January 23, 2023 20:31
Patrik-Stas
Patrik-Stas previously approved these changes Jan 24, 2023
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the wrappers/expose-nonmediated-connection branch from 7ee5a17 to c6304ca Compare January 24, 2023 15:42
@mirgee mirgee marked this pull request as ready for review January 24, 2023 18:19
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the wrappers/expose-nonmediated-connection branch from 5c16b12 to c8b1a79 Compare January 24, 2023 19:11
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@mirgee mirgee force-pushed the wrappers/expose-nonmediated-connection branch from c8b1a79 to c4fa2b5 Compare January 24, 2023 19:57
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@Patrik-Stas Patrik-Stas merged commit 66ee076 into main Jan 25, 2023
@Patrik-Stas Patrik-Stas deleted the wrappers/expose-nonmediated-connection branch January 25, 2023 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants