Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the signature of a VcxApi implementation method #748

Merged

Conversation

raphaelguye
Copy link
Contributor

Fixing the signature of the implementation to match the one from the header to avoid a crash when calling the function.

VcxAPI.h:

VcxAPI.m:

Signed-off-by: Raphael Guye <raphael.guye@gmail.com>
@raphaelguye raphaelguye changed the title Fix the signature VcxApi implementation method Fix the signature of a VcxApi implementation method Feb 9, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #748 (cf026ee) into main (66ee076) will decrease coverage by 24.53%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #748       +/-   ##
===========================================
- Coverage   54.73%   30.20%   -24.53%     
===========================================
  Files         363      361        -2     
  Lines       37122    30713     -6409     
  Branches     8089     6305     -1784     
===========================================
- Hits        20317     9276    -11041     
- Misses      10832    18684     +7852     
+ Partials     5973     2753     -3220     
Flag Coverage Δ
unittests-aries-vcx 30.20% <ø> (-24.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tocols/proof_presentation/prover/states/initial.rs 0.00% <0.00%> (-100.00%) ⬇️
...cols/proof_presentation/verifier/states/initial.rs 0.00% <0.00%> (-100.00%) ⬇️
aries_vcx/src/handlers/discovery/mod.rs 0.00% <0.00%> (-93.94%) ⬇️
aries_vcx/tests/utils/scenarios.rs 0.00% <0.00%> (-80.47%) ⬇️
libvdrtools/src/domain/ledger/request.rs 0.00% <0.00%> (-79.49%) ⬇️
aries_vcx/src/utils/provision.rs 0.00% <0.00%> (-77.78%) ⬇️
...ies_vcx/src/core/profile/modular_wallet_profile.rs 0.00% <0.00%> (-76.48%) ⬇️
aries_vcx/src/plugins/anoncreds/indy_anoncreds.rs 2.70% <0.00%> (-75.68%) ⬇️
libvdrtools/src/services/pool/networker.rs 0.00% <0.00%> (-75.11%) ⬇️
...rtools/src/domain/anoncreds/revocation_registry.rs 0.00% <0.00%> (-75.00%) ⬇️
... and 228 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Patrik-Stas Patrik-Stas merged commit 87c3ff3 into hyperledger:main Feb 13, 2023
@raphaelguye raphaelguye deleted the wrappers/fix-vcxapi-impl-signature branch February 14, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants