Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NodeJS testing CI #750

Merged
merged 1 commit into from Feb 14, 2023
Merged

Fix NodeJS testing CI #750

merged 1 commit into from Feb 14, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented Feb 13, 2023

NodeJS CI testing changes:

Signed-off-by: Patrik Stas patrik.stas@absa.africa

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #750 (08e9c02) into main (66ee076) will decrease coverage by 7.46%.
The diff coverage is n/a.

❗ Current head 08e9c02 differs from pull request most recent head 3484db9. Consider uploading reports for the commit 3484db9 to get more accurate results

@@            Coverage Diff             @@
##             main     #750      +/-   ##
==========================================
- Coverage   54.73%   47.27%   -7.46%     
==========================================
  Files         363      381      +18     
  Lines       37122    32908    -4214     
  Branches     8089     7052    -1037     
==========================================
- Hits        20317    15558    -4759     
- Misses      10832    12699    +1867     
+ Partials     5973     4651    -1322     
Flag Coverage Δ
unittests-aries-vcx 47.26% <ø> (-7.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/utils/constants.rs 0.00% <0.00%> (-100.00%) ⬇️
messages/src/protocols/proof_presentation/mod.rs 0.00% <0.00%> (-100.00%) ⬇️
...rotocols/issuance/issuer/states/credential_sent.rs 0.00% <0.00%> (-88.89%) ⬇️
...evocation_notification/receiver/states/finished.rs 0.00% <0.00%> (-81.82%) ⬇️
...evocation_notification/receiver/states/received.rs 0.00% <0.00%> (-81.82%) ⬇️
aries_vcx/src/lib.rs 25.00% <0.00%> (-75.00%) ⬇️
.../revocation_notification/sender/states/finished.rs 0.00% <0.00%> (-75.00%) ⬇️
...s_vcx/src/utils/mockdata/profile/mock_anoncreds.rs 0.00% <0.00%> (-71.62%) ⬇️
...s_vcx/src/protocols/revocation_notification/mod.rs 0.00% <0.00%> (-70.84%) ⬇️
...essages/src/protocols/connection/problem_report.rs 0.00% <0.00%> (-69.24%) ⬇️
... and 232 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

… 22 hosts

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@Patrik-Stas Patrik-Stas changed the title nodejs CI issues investigation Fix NodeJS testing CI Feb 13, 2023
@Patrik-Stas Patrik-Stas marked this pull request as ready for review February 13, 2023 19:30
@Patrik-Stas Patrik-Stas merged commit a85a55f into main Feb 14, 2023
@Patrik-Stas Patrik-Stas deleted the ci/nodejs branch February 14, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants