Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose createServiceV2 #756

Merged
merged 2 commits into from Feb 19, 2023
Merged

Expose createServiceV2 #756

merged 2 commits into from Feb 19, 2023

Conversation

mirgee
Copy link
Contributor

@mirgee mirgee commented Feb 17, 2023

Expose writing the endpoint ATTRIB in the format conforming with Sovrin DID method spec to node wrapper.

Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
Signed-off-by: Miroslav Kovar <miroslav.kovar@absa.africa>
@codecov-commenter
Copy link

Codecov Report

Merging #756 (3964b14) into main (b1dbbe2) will decrease coverage by 24.85%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main     #756       +/-   ##
===========================================
- Coverage   54.65%   29.81%   -24.85%     
===========================================
  Files         381      379        -2     
  Lines       37155    30610     -6545     
  Branches     8067     6298     -1769     
===========================================
- Hits        20308     9125    -11183     
- Misses      10892    18775     +7883     
+ Partials     5955     2710     -3245     
Flag Coverage Δ
unittests-aries-vcx 29.81% <ø> (-24.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tocols/proof_presentation/prover/states/initial.rs 0.00% <0.00%> (-100.00%) ⬇️
...cols/proof_presentation/verifier/states/initial.rs 0.00% <0.00%> (-100.00%) ⬇️
aries_vcx/src/handlers/discovery/mod.rs 0.00% <0.00%> (-93.94%) ⬇️
...ies_vcx/src/core/profile/modular_wallet_profile.rs 0.00% <0.00%> (-81.25%) ⬇️
aries_vcx/tests/utils/scenarios.rs 0.00% <0.00%> (-80.47%) ⬇️
libvdrtools/src/domain/ledger/request.rs 0.00% <0.00%> (-79.49%) ⬇️
aries_vcx/src/utils/provision.rs 0.00% <0.00%> (-77.78%) ⬇️
aries_vcx/src/plugins/anoncreds/indy_anoncreds.rs 2.68% <0.00%> (-75.47%) ⬇️
libvdrtools/src/services/pool/networker.rs 0.00% <0.00%> (-75.11%) ⬇️
...rtools/src/domain/anoncreds/revocation_registry.rs 0.00% <0.00%> (-75.00%) ⬇️
... and 249 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Patrik-Stas
Copy link
Contributor

Is this ready for merge? It's draft, but seems complete

@mirgee mirgee marked this pull request as ready for review February 19, 2023 18:58
@Patrik-Stas Patrik-Stas merged commit 2c0ec21 into main Feb 19, 2023
@Patrik-Stas Patrik-Stas deleted the wrapper/create-service-v2 branch February 19, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants