Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump time to 0.3.20 #800

Merged
merged 2 commits into from
Apr 27, 2023
Merged

Bump time to 0.3.20 #800

merged 2 commits into from
Apr 27, 2023

Conversation

swaptr
Copy link
Contributor

@swaptr swaptr commented Apr 12, 2023

This PR addresses the breaking changes in the time crate dependency.
This PR aims to upgrade time to 0.3.20.
Fixes #795

@Patrik-Stas
Copy link
Contributor

Thank you @swaptr! Let's wait for CI

@swaptr swaptr force-pushed the time branch 3 times, most recently from ba1cded to fd36ee5 Compare April 12, 2023 23:22
@swaptr
Copy link
Contributor Author

swaptr commented Apr 12, 2023

Thank you @Patrik-Stas for reviewing the PR. I think CI should work now. Also idk for some reason I am having trouble with signing commits, hence I have to squash and force push as a workaround. Until I fix this, I hope this is not an issue.

@Patrik-Stas
Copy link
Contributor

Hi @swaptr seems like you've figured out the DCO. There's a failure in CI - test can't yet compile.

Have a look please, seems like some additional tweak are required. You can easily verify the compilation locally

 cargo check -F 'pool_tests agency_pool_tests'

and also

cargo check -F 'general_test'

running these 2 command from root directory of the repo.

Thank you!

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2023

Codecov Report

Merging #800 (fe41ce8) into main (ca7bb8f) will increase coverage by 0.01%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #800      +/-   ##
==========================================
+ Coverage   48.95%   48.97%   +0.01%     
==========================================
  Files         410      410              
  Lines       33458    33462       +4     
  Branches     7426     7425       -1     
==========================================
+ Hits        16380    16388       +8     
+ Misses      11978    11977       -1     
+ Partials     5100     5097       -3     
Flag Coverage Δ
unittests-aries-vcx 48.94% <88.88%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
libvdrtools/src/services/pool/types.rs 12.59% <0.00%> (ø)
libvdrtools/src/services/pool/networker.rs 75.80% <91.66%> (+0.29%) ⬆️
aries_vcx/src/common/credentials/mod.rs 73.03% <100.00%> (ø)
aries_vcx/src/common/primitives/mod.rs 79.01% <100.00%> (ø)
aries_vcx/src/common/signing.rs 45.83% <100.00%> (ø)
aries_vcx/tests/test_creds_proofs.rs 87.30% <100.00%> (ø)
aries_vcx/tests/test_creds_proofs_revocations.rs 86.30% <100.00%> (ø)
aries_vcx_core/src/indy/ledger/transactions.rs 45.08% <100.00%> (ø)
aries_vcx_core/src/ledger/indy_vdr_ledger.rs 32.87% <100.00%> (ø)
libvdrtools/src/domain/ledger/request.rs 78.94% <100.00%> (+0.56%) ⬆️

... and 4 files with indirect coverage changes

@Patrik-Stas
Copy link
Contributor

hi @swaptr are you willing to further drive this PR to completion? It seems there's still some work outstanding

  • resolve confilicts
  • assure tests can be compiled and CI is passing

Additionally note we are now in bit of a freeze mode for couple day, waiting for #787 to be completed.
Perhaps it's best to wait for that to get merged and then proceed with addressing the points above.

@swaptr
Copy link
Contributor Author

swaptr commented Apr 20, 2023

I am sorry for the delayed work on this PR. Thank you for your patience, although I did fix test compilations but as per your instructions I will update this PR once again after the freeze is over.

Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
@swaptr
Copy link
Contributor Author

swaptr commented Apr 27, 2023

@Patrik-Stas, I have fixed majority of the issues with this PR, but somehow the CI is still failing. I am out of ideas to fix this, can you look into this?

@Patrik-Stas Patrik-Stas merged commit e5545d4 into hyperledger:main Apr 27, 2023
40 of 41 checks passed
@Patrik-Stas
Copy link
Contributor

hi @swaptr it's was a false positive failure. Not your fault, we'll have to tweak our CI to prevent this from happening on "from-fork" PRs

@Patrik-Stas
Copy link
Contributor

Merged now :-) Thank you for contribution!

tech-bash pushed a commit to tech-bash/aries-vcx that referenced this pull request Apr 30, 2023
Signed-off-by: Swapnil Tripathi <swapnil06.st@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update time crate dependency to version 0.3.x
3 participants