unit tests for credential_schema::Schema #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #808 +/- ##
==========================================
+ Coverage 48.95% 49.04% +0.08%
==========================================
Files 410 410
Lines 33458 33497 +39
Branches 7426 7441 +15
==========================================
+ Hits 16380 16428 +48
+ Misses 11978 11952 -26
- Partials 5100 5117 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
hi @nachiketkanore thank you for contribution! The CI looks green, but DCO check is currently failing. No worries is simple fix! Have a look here https://github.com/hyperledger/aries-vcx/pull/808/checks?check_run_id=12831789658 what DCO means and then you'll have to push force again. Thank you! |
Patrik-Stas
previously approved these changes
Apr 19, 2023
…schema_id (easy) Signed-off-by: Nachiket Kanore <nachiket.kanore@gmail.com>
nachiketkanore
force-pushed
the
unit-tests
branch
from
2161620
to
ccadc7a
Compare
|
Done |
Patrik-Stas
approved these changes
Apr 27, 2023
tech-bash
pushed a commit
to tech-bash/aries-vcx
that referenced
this pull request
Apr 30, 2023
…schema_id (easy) (hyperledger#808) Signed-off-by: Nachiket Kanore <nachiket.kanore@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema#775to_string_versioned,from_string_versioned,get_schema_id