Refactor of the iOS CI #823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobozaur
force-pushed
the
refactor/ios_ci
branch
6 times, most recently
from
4214001
to
68ced47
Compare
Codecov Report
@@ Coverage Diff @@
## main #823 +/- ##
==========================================
- Coverage 49.00% 49.00% -0.01%
==========================================
Files 414 414
Lines 33694 33694
Branches 7462 7445 -17
==========================================
- Hits 16513 16512 -1
- Misses 12064 12065 +1
Partials 5117 5117
Flags with carried forward coverage won't be shown. Click here to find out more. |
Patrik-Stas
previously approved these changes
May 8, 2023
|
pending verification of the build from @raphaelguye's team if there's no issues, we can merge this |
Patrik-Stas
approved these changes
May 15, 2023
Signed-off-by: Bogdan Mircea <mirceapetrebogdan@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor aims to improve the CI speed of the iOS build by removing unnecessary targets and vendoring our own build scripts for the libsodium and zeromq libraries (to avoid some unnecessary operations from the previous scripts).