Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setting txn author agreement #824

Merged
merged 3 commits into from
May 3, 2023
Merged

Fix setting txn author agreement #824

merged 3 commits into from
May 3, 2023

Conversation

Patrik-Stas
Copy link
Contributor

@Patrik-Stas Patrik-Stas commented May 2, 2023

  • 0.55.0 release contained bug that transaction author agreement doesn't get set up in global settings state of aries-vcx-core, therefore ledger writes doesn't work for indy ledgers which require transaction author agreement
  • this fixes the issue

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
@codecov-commenter
Copy link

Codecov Report

Merging #824 (6c3f9ea) into main (036bbf9) will decrease coverage by 0.75%.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##             main     #824      +/-   ##
==========================================
- Coverage   49.06%   48.31%   -0.75%     
==========================================
  Files         410      410              
  Lines       33501    33468      -33     
  Branches     7440     7428      -12     
==========================================
- Hits        16436    16170     -266     
- Misses      11949    12221     +272     
+ Partials     5116     5077      -39     
Flag Coverage Δ
unittests-aries-vcx 48.28% <7.69%> (-0.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aries_vcx/src/utils/author_agreement.rs 0.00% <0.00%> (-71.16%) ⬇️
aries_vcx_core/src/global/settings.rs 54.38% <0.00%> (-6.40%) ⬇️
aries_vcx_core/src/indy/ledger/transactions.rs 40.59% <0.00%> (-4.49%) ⬇️
aries_vcx_core/src/ledger/indy_vdr_ledger.rs 32.87% <0.00%> (ø)
aries_vcx_core/src/utils/mod.rs 100.00% <ø> (ø)
aries_vcx_core/src/utils/author_agreement.rs 8.33% <50.00%> (ø)

... and 58 files with indirect coverage changes

@Patrik-Stas Patrik-Stas requested a review from mirgee May 3, 2023 06:53
@Patrik-Stas Patrik-Stas merged commit e380aac into main May 3, 2023
41 checks passed
@Patrik-Stas Patrik-Stas deleted the fix/tx-agreement branch May 3, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants