Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup/ffi leftovers #825

Merged
merged 3 commits into from
May 5, 2023
Merged

Cleanup/ffi leftovers #825

merged 3 commits into from
May 5, 2023

Conversation

Patrik-Stas
Copy link
Contributor

No description provided.

@Patrik-Stas Patrik-Stas changed the base branch from main to fix/tx-agreement May 2, 2023 15:32
@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Merging #825 (7138b73) into main (e380aac) will decrease coverage by 3.84%.
The diff coverage is 51.42%.

❗ Current head 7138b73 differs from pull request most recent head c19f364. Consider uploading reports for the commit c19f364 to get more accurate results

@@            Coverage Diff             @@
##             main     #825      +/-   ##
==========================================
- Coverage   48.99%   45.15%   -3.84%     
==========================================
  Files         410      408       -2     
  Lines       33468    33463       -5     
  Branches     7427     7433       +6     
==========================================
- Hits        16397    15111    -1286     
- Misses      11967    13584    +1617     
+ Partials     5104     4768     -336     
Flag Coverage Δ
unittests-aries-vcx 45.15% <51.42%> (-3.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...vcx/src/common/primitives/credential_definition.rs 50.00% <0.00%> (-4.50%) ⬇️
aries_vcx/src/global/author_agreement.rs 0.00% <0.00%> (ø)
aries_vcx/src/utils/mockdata/mock_settings.rs 17.07% <ø> (-14.93%) ⬇️
...s_vcx/src/utils/mockdata/profile/mock_anoncreds.rs 0.00% <ø> (-42.02%) ⬇️
...ries_vcx/src/utils/mockdata/profile/mock_ledger.rs 0.00% <ø> (-27.48%) ⬇️
aries_vcx/src/utils/mod.rs 58.33% <ø> (ø)
aries_vcx_core/src/indy/credentials/issuer/mod.rs 61.11% <ø> (+6.11%) ⬆️
aries_vcx_core/src/indy/proofs/prover/prover.rs 51.02% <ø> (ø)
aries_vcx_core/src/indy/utils/mod.rs 23.80% <0.00%> (-9.53%) ⬇️
aries_vcx_core/src/ledger/indy_vdr_ledger.rs 32.87% <0.00%> (ø)
... and 5 more

... and 52 files with indirect coverage changes

Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Signed-off-by: Patrik Stas <patrik.stas@absa.africa>
Copy link
Contributor

@bobozaur bobozaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bobozaur bobozaur merged commit c9c4006 into main May 5, 2023
12 of 27 checks passed
@bobozaur bobozaur deleted the cleanup/ffi-leftovers branch May 5, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants